Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PodNetworkConnectivityChecks #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cptmorgan-rh
Copy link

PodNetworkConnectivityChecks are saved in the must-gather under <mg.path>/pod_network_connectivity_check/podnetworkconnectivitychecks.yaml

This adds support to omc by allowing you to view them by running omc get podnetworkconnectivitychecks -n openshift-diagnostics

$ omc get podnetworkconnectivitychecks -n openshift-network-diagnostics
NAME                                                            AGE
network-check-source-10-to-kubernetes-default-service-cluster   239d

@cptmorgan-rh cptmorgan-rh changed the title Add supports for PodNetworkConnectivityChecks Add support for PodNetworkConnectivityChecks Aug 6, 2024
@gmeghnag
Copy link
Owner

Hey @cptmorgan-rh thank you for the PR, I'll merge it, but I'm wondering why the podnetworkconnectivitycheck.controlplane.operator.openshift.io resources are not located into their namespace folder, as they should be, do you have any idea?

@cptmorgan-rh
Copy link
Author

@gmeghnag - I am the author of the script that pulls the files in the must-gather. I can't remember why we placed them in their own folder and not in their namespace. Would have made accessing them a lot easier with omc.

@gmeghnag
Copy link
Owner

@cptmorgan-rh Yes, as it would not have required modifying the omc code to inspect these resources, can you modify the must-gather script so we can avoid making this change here?

@cptmorgan-rh
Copy link
Author

The code has been there for over two years so I'm not sure they will. I can ask and let you know.

@gmeghnag
Copy link
Owner

gmeghnag commented Sep 2, 2024

@cptmorgan-rh did you have any chance to check it?

@cptmorgan-rh
Copy link
Author

@gmeghnag

Insights rules exist for the file location so we can't change it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants